FIx error when building with oneAPI release compiler #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammad-tanvir-1211
requested review from
s-Nick,
pgorlani,
OuadiElfarouki and
aacostadiaz
|
If the purpose of the patch is removing the warning during the unit test/benchmark compilation, it would be better to set
|
pgorlani
approved these changes
Feb 23, 2024
OuadiElfarouki
approved these changes
Feb 23, 2024
muhammad-tanvir-1211
merged commit 2f149cb
into
codeplaysoftware:master
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error seen from
googlebenchandgtest(warning in this case) that explicit comparison with NaN is not allowed in fast precision mode.